Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the stream cargo feature #2855

Closed
seanmonstar opened this issue May 20, 2022 · 0 comments
Closed

Remove the stream cargo feature #2855

seanmonstar opened this issue May 20, 2022 · 0 comments
Labels
A-body Area: body streaming. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Milestone
1.0 RC1

Comments

@seanmonstar
Copy link
Member

The stream cargo feature should be removed, and any usage of Stream. It's not stable, and we cannot depend on it.

  • This means accept::from_stream, (which Accept is already going away anyways).
  • Body::wrap_stream
  • impl Stream for Body
@seanmonstar seanmonstar added A-server Area: server. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. A-body Area: body streaming. labels May 20, 2022
@seanmonstar seanmonstar added this to the 1.0 milestone May 20, 2022
oddgrd added a commit to oddgrd/hyper that referenced this issue May 25, 2022
@oddgrd
feat(body): remove stream cargo feature
77f149e 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
oddgrd added a commit to oddgrd/hyper that referenced this issue May 25, 2022
@oddgrd
feat(body): remove stream cargo feature
b44898c 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
oddgrd added a commit to oddgrd/hyper that referenced this issue May 26, 2022
@oddgrd
feat(body): remove stream cargo feature
d77db69 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
oddgrd added a commit to oddgrd/hyper that referenced this issue May 26, 2022
@oddgrd
feat(body): remove stream cargo feature
f97d19c 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
oddgrd added a commit to oddgrd/hyper that referenced this issue Jun 14, 2022
@oddgrd
feat(body): remove stream cargo feature
2415aa6 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
@oddgrd oddgrd mentioned this issue Jun 14, 2022
Merged
oddgrd added a commit to oddgrd/hyper that referenced this issue Jun 14, 2022
@oddgrd
feat(body): remove stream cargo feature
f855b2e 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
@seanmonstar seanmonstar moved this to Todo in hyper 1.0 Jun 15, 2022
@seanmonstar seanmonstar moved this from Todo to In Progress in hyper 1.0 Jun 15, 2022
oddgrd added a commit to oddgrd/hyper that referenced this issue Jun 17, 2022
@oddgrd
feat(body): remove stream cargo feature
31a8be1 
remove stream cargo feature and any usage of stream, as it isn't stable and shouldn't be depended on

closes issue hyperium#2855
Repository owner moved this from In Progress to Done in hyper 1.0 Jun 23, 2022
@dmeijboom dmeijboom mentioned this issue Oct 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-body Area: body streaming. A-server Area: server. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
No open projects
hyper 1.0
Status: Done
Milestone
1.0 RC1
Development

No branches or pull requests
1 participant
@seanmonstar