Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Send"able request builder #254

Closed
richard-uk1 opened this issue Jan 18, 2015 · 1 comment
Closed

"Send"able request builder #254

richard-uk1 opened this issue Jan 18, 2015 · 1 comment
Labels
A-client Area: client.

Comments

@richard-uk1
Copy link
Contributor

How difficult would it be to make the request builder sendable, so a user of the lib could create a request builder and then send it to a helper task while it blocks on network io?

@seanmonstar
Copy link
Member

I'm not sure about difficulty, but it must happen. It's a goal that you can
have multiple requests running at the same time, but current design impedes
that.

On Sun, Jan 18, 2015, 7:14 AM derekdreery [email protected] wrote:

How difficult would it be to make the request builder sendable, so a user
of the lib could create a request builder and then send it to a helper task
while it blocks on network io?


Reply to this email directly or view it on GitHub
#254.

@reem reem added the A-client Area: client. label Jan 19, 2015
seanmonstar added a commit that referenced this issue Jun 12, 2015
Connector::connect already used &self, and so would require
synchronization to be handled per connector anyway. Adding Sync to the
Client allows users to setup config for a Client once, such as using a
single connection Pool, and then making requests across multiple
threads.

Closes #254

BREAKING CHANGE: Connectors and Protocols passed to the `Client` must
  now also have a `Sync` bounds, but this shouldn't break default usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client.
Projects
None yet
Development

No branches or pull requests

3 participants