Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reuse_address(true) to client connections #1599

Closed
EliSnow opened this issue Jul 10, 2018 · 3 comments
Closed

Add reuse_address(true) to client connections #1599

EliSnow opened this issue Jul 10, 2018 · 3 comments
Labels
A-client Area: client. B-rfc Blocked: More comments would be useful in determine next steps.

Comments

@EliSnow
Copy link

EliSnow commented Jul 10, 2018

I'm experimenting with using hyper to run load tests and ephemeral port exhaustion is a real problem. Can reuse_address(true) be added to the client connection code (here, and here, I believe)?

Would making the change here also apply to tls connections made using hyper_tls?

@seanmonstar
Copy link
Member

I haven't thought this through at all, so some questions: would this cause problems for people who weren't expecting this? Could people assume that they normally would have different ports? If so, perhaps this would just be an option on HttpConnector?

@seanmonstar seanmonstar added A-client Area: client. B-rfc Blocked: More comments would be useful in determine next steps. labels Jul 10, 2018
@EliSnow
Copy link
Author

EliSnow commented Jul 10, 2018

I would be perfectly fine with just having the option of enabling it. Does that mean hyper_tls would have to add an option for reuse_address to apply to https connections?

@seanmonstar
Copy link
Member

hyper-tls has a constructor that allows you configure a connector first, so it wouldn't need any changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: client. B-rfc Blocked: More comments would be useful in determine next steps.
Projects
None yet
Development

No branches or pull requests

2 participants