Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add struct for TE header field #1109

Closed
sector-f opened this issue Apr 1, 2017 · 1 comment
Closed

Add struct for TE header field #1109

sector-f opened this issue Apr 1, 2017 · 1 comment
Labels
A-headers Area: headers. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@sector-f
Copy link

sector-f commented Apr 1, 2017

The TE header field is similar to Accept-Encoding, but for the Transfer-Encoding instead of the Content-Encoding

https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/TE
Section 14.39 https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html
@seanmonstar seanmonstar added E-easy Effort: easy. A task that would be a great starting point for a new contributor. A-headers Area: headers. labels Apr 17, 2017
@almielczarek
Copy link
Contributor

almielczarek commented Apr 22, 2017 •
edited
Loading

I'm interested in helping with this!

Just to make sure I am on the right track, I think what I should do is implement the TE struct using the header! macro, passing the QualityItem<Encoding> struct as this also has a notion of quality values, adding the Trailer variant to the Encoding enum and adding it to the related impls, and then writing the documentation based off of RFC7230. Does this make sense or am I missing something?

This was referenced Apr 24, 2017
Closed
Merged
pzread pushed a commit to furakus/hyper that referenced this issue May 1, 2017
@almielczarek @pzread
feat(headers): add TE header struct (hyperium#1150)
51d3853 
The `TE` header is used by a client to specify which
transfer encodings other than `chunked` it will accept.
It also specifies whether HTTP trailers are acceptable.
This commit also adds a `Trailers` variant to the
`hyper::header::shared::Encoding` enum.

Closes hyperium#1109 

BREAKING CHANGE: The `Encoding` enum has an additional
  variant, `Trailers`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-headers Area: headers. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanmonstar @almielczarek @sector-f