-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL #1
Comments
ssl support for the client exists, still lacking server support |
Is it alright if I take a stab at this? |
@cactorium I'd be delighted if this showed up as a PR :D Some notes: I'd imagine adding a |
@seanmonstar Awesome :D I think I did it? #199 I'm still working on figuring out how to test it, but here's something to look at for now |
What's the story for certificate validation in the client? |
https://github.com/hyperium/hyper/blob/master/src/net.rs#L257 It looks like they're verified, peek around there and the openssl docs if you want more details: https://www.openssl.org/docs/ssl/SSL_CTX_set_verify.html |
Thanks: so (rust-)openssl does verification, but is something required on the hyper side? I see there's no default verifier included and the provided client example accepts everything for me. Is this expected? Should I file a bug for this? |
@veeti you can set a verifier function on Client. I guess a default could be similar to Python or nodejs. |
Update servo branch for rust upgrade + rustc workaround for SendStr issue.
Implements the missing enum cases in Http* and adds a new method to the default Server implementation to take advantage of the new TLS support Closes hyperium#1
No description provided.
The text was updated successfully, but these errors were encountered: