Skip to content

Commit

Permalink
feat(headers): re-export CookiePair and CookieJar
Browse files Browse the repository at this point in the history
  • Loading branch information
seanmonstar committed Nov 20, 2015
1 parent 81d42c9 commit 799698c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 14 deletions.
5 changes: 1 addition & 4 deletions src/header/common/cookie.rs
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
use header::{Header, HeaderFormat};
use header::{Header, HeaderFormat, CookiePair, CookieJar};
use std::fmt::{self, Display};
use std::str::from_utf8;

use cookie::Cookie as CookiePair;
use cookie::CookieJar;

/// `Cookie` header, defined in [RFC6265](http://tools.ietf.org/html/rfc6265#section-5.4)
///
/// If the user agent does attach a Cookie header field to an HTTP
Expand Down
18 changes: 8 additions & 10 deletions src/header/common/set_cookie.rs
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
use header::{Header, HeaderFormat};
use header::{Header, HeaderFormat, CookiePair, CookieJar};
use std::fmt::{self, Display};
use std::str::from_utf8;

use cookie::Cookie;
use cookie::CookieJar;

/// `Set-Cookie` header, defined [RFC6265](http://tools.ietf.org/html/rfc6265#section-4.1)
///
Expand Down Expand Up @@ -80,9 +78,9 @@ use cookie::CookieJar;
/// # }
/// ```
#[derive(Clone, PartialEq, Debug)]
pub struct SetCookie(pub Vec<Cookie>);
pub struct SetCookie(pub Vec<CookiePair>);

__hyper__deref!(SetCookie => Vec<Cookie>);
__hyper__deref!(SetCookie => Vec<CookiePair>);

impl Header for SetCookie {
fn header_name() -> &'static str {
Expand Down Expand Up @@ -142,7 +140,7 @@ impl SetCookie {
#[test]
fn test_parse() {
let h = Header::parse_header(&[b"foo=bar; HttpOnly".to_vec()][..]);
let mut c1 = Cookie::new("foo".to_owned(), "bar".to_owned());
let mut c1 = CookiePair::new("foo".to_owned(), "bar".to_owned());
c1.httponly = true;

assert_eq!(h.ok(), Some(SetCookie(vec![c1])));
Expand All @@ -152,10 +150,10 @@ fn test_parse() {
fn test_fmt() {
use header::Headers;

let mut cookie = Cookie::new("foo".to_owned(), "bar".to_owned());
let mut cookie = CookiePair::new("foo".to_owned(), "bar".to_owned());
cookie.httponly = true;
cookie.path = Some("/p".to_owned());
let cookies = SetCookie(vec![cookie, Cookie::new("baz".to_owned(), "quux".to_owned())]);
let cookies = SetCookie(vec![cookie, CookiePair::new("baz".to_owned(), "quux".to_owned())]);
let mut headers = Headers::new();
headers.set(cookies);

Expand All @@ -167,7 +165,7 @@ fn test_fmt() {
#[test]
fn cookie_jar() {
let jar = CookieJar::new(b"secret");
let cookie = Cookie::new("foo".to_owned(), "bar".to_owned());
let cookie = CookiePair::new("foo".to_owned(), "bar".to_owned());
jar.add(cookie);

let cookies = SetCookie::from_cookie_jar(&jar);
Expand All @@ -176,5 +174,5 @@ fn cookie_jar() {
cookies.apply_to_cookie_jar(&mut new_jar);

assert_eq!(jar.find("foo"), new_jar.find("foo"));
assert_eq!(jar.iter().collect::<Vec<Cookie>>(), new_jar.iter().collect::<Vec<Cookie>>());
assert_eq!(jar.iter().collect::<Vec<CookiePair>>(), new_jar.iter().collect::<Vec<CookiePair>>());
}
2 changes: 2 additions & 0 deletions src/header/shared/mod.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
pub use self::charset::Charset;
pub use cookie::Cookie as CookiePair;
pub use cookie::CookieJar;
pub use self::encoding::Encoding;
pub use self::entity::EntityTag;
pub use self::httpdate::HttpDate;
Expand Down

0 comments on commit 799698c

Please sign in to comment.