Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow using as_u16 in const contexts #680

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow using as_u16 in const contexts #680

wants to merge 2 commits into from

Conversation

WhyNotHugo
Copy link

No description provided.

WhyNotHugo
WhyNotHugo commented Feb 21, 2024
View reviewed changes
src/status.rs
pub fn as_u16(&self) -> u16 {
(*self).into()
pub const fn as_u16(&self) -> u16 {
(*self).0.get()
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hint for reviewers: into() did exactly this under the hood.

@WhyNotHugo WhyNotHugo mentioned this pull request Feb 21, 2024
Open
y-haidar
y-haidar approved these changes Feb 21, 2024
View reviewed changes
Copy link

@y-haidar y-haidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there are any downside to this. MSRV support const fn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-haidar y-haidar y-haidar approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhyNotHugo @y-haidar