move datagram to separate crate #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Generally looks great, good work!
Might be good if @darioalessandro or @ten3roberts could look, to see if they can still use it.
h3-quinn/Cargo.toml
Outdated
| @@ -21,6 +21,7 @@ quinn = { version = "0.11", default-features = false, features = [ | |||
| tokio-util = { version = "0.7.9" } | |||
| futures = { version = "0.3.28" } | |||
| tokio = { version = "1", features = ["io-util"], default-features = false } | |||
| h3-datagram = { path = "../h3-datagram" } | |||
There was a problem hiding this comment.
Wondering, should it be optional? Is there enough code in here that people would benefit if they didn't need to compile it?
There was a problem hiding this comment.
Wondering, should it be optional? Is there enough code in here that people would benefit if they didn't need to compile it?
Changed it.
Ruben2424
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of This PR is to separate the h3-datagram logic from the
h3crate providing a new crateh3-datagram.