pr/799 #816
Merged
pr/799 #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensure local stream is released properly Similar to what have been done in fn send_reset<B>(), we should notify RecvStream that is parked after send_reset().
seanmonstar
added a commit
that referenced
this pull request
Nov 12, 2024
…ensure local stream is released properly (#816) Similar to what have been done in fn send_reset<B>(), we should notify RecvStream that is parked after send_reset(). Co-authored-by: Jiahao Liang <[email protected]>
seanmonstar
added a commit
that referenced
this pull request
Nov 12, 2024
…ensure local stream is released properly (#816) (#818) Similar to what have been done in fn send_reset<B>(), we should notify RecvStream that is parked after send_reset(). Co-authored-by: Jiahao Liang <[email protected]>
cxw620
pushed a commit
to cxw620/h2
that referenced
this pull request
Jan 20, 2025
* chore: allow matching infallible (hyperium#796) * v0.4.6 * chore(ci): use tokio-util 0.7.11 in MSRV check * style: replace `split_to` and `split_off` with better alternatives This removes `let _ = ` from in front of `split_to` and `split_off` and mostly follows the suggestions from the `#[must_use]` impls. One of the uses of `split_to` is instead replaced with `take`. * improve ci/h2spec.sh (macOS compat, /tmp dir and overwrite) (hyperium#809) - detect if run on MacOS, so we download h2spec macos build in that case - support overwriting h2spec detection so we anyway download new file, useful in case you switch to new version for example - move h2spec, archive and log all to /tmp dir as to not polute the repo dir * ci: pin hashbrown for msrv job (hyperium#814) * fix: HEADERS frame with non-zero content-length and END_STREAM is malformed (hyperium#813) Before this change, content-length underflow is only checked when receiving date frames. The underflow error was never triggered if data frames are never received. This change adds similar check for headers frames. * fix: notify_recv after send_reset() in reset_on_recv_stream_err() to ensure local stream is released properly (hyperium#816) (hyperium#818) Similar to what have been done in fn send_reset<B>(), we should notify RecvStream that is parked after send_reset(). Co-authored-by: Jiahao Liang <[email protected]> --------- Co-authored-by: Sean McArthur <[email protected]> Co-authored-by: tottoto <[email protected]> Co-authored-by: Paolo Barbolini <[email protected]> Co-authored-by: Glen De Cauwsemaecker <[email protected]> Co-authored-by: Yuchen Wu <[email protected]> Co-authored-by: Jiahao Liang <[email protected]>
cxw620
pushed a commit
to cxw620/h2
that referenced
this pull request
Jan 20, 2025
* v0.3.26 * Rename project to `rh2` * Refactor frame sending custom implementation * Export frame `PseudoOrder` settings * Reduce unnecessary Option packaging * v0.3.27 * fix(frame/headers): Fix error when headers priority is empty * v0.3.29 * feat(frame/headers): Packaging headers pseudo order type (hyperium#8) * feat(frame/settings): Packaging settings type (hyperium#9) * Initialize frame settings order in advance * v0.3.31 * feat(frame): Add unknown_setting frame settings (hyperium#10) * Add unknown_setting patch * Customize all Http Settings order * v0.3.40 * fix(frame): Fix unknown setting encode (hyperium#11) * v0.3.41 * feat: Replace with static settings (hyperium#12) * v0.3.50 * feat: Destructive update, fixed-length array records the setting frame order (hyperium#13) * v0.3.60 * Update README.md * Sync upstream (hyperium#14) * fix: streams awaiting capacity lockout (hyperium#730) (hyperium#734) This PR changes the the assign-capacity queue to prioritize streams that are send-ready. This is necessary to prevent a lockout when streams aren't able to proceed while waiting for connection capacity, but there is none. Closes hyperium/hyper#3338 Co-authored-by: dswij <[email protected]> * v0.3.23 * streams: limit error resets for misbehaving connections This change causes GOAWAYs to be issued to misbehaving connections which for one reason or another cause us to emit lots of error resets. Error resets are not generally expected from valid implementations anyways. The threshold after which we issue GOAWAYs is tunable, and will default to 1024. * Prepare v0.3.24 * perf: optimize header list size calculations (hyperium#750) This speeds up loading blocks in cases where we have many headers already. * v0.3.25 * refactor: cleanup new unused warnings (hyperium#757) * fix: limit number of CONTINUATION frames allowed Calculate the amount of allowed CONTINUATION frames based on other settings. max_header_list_size / max_frame_size That is about how many CONTINUATION frames would be needed to send headers up to the max allowed size. We then multiply by that by a small amount, to allow for implementations that don't perfectly pack into the minimum frames *needed*. In practice, *much* more than that would be a very inefficient peer, or a peer trying to waste resources. See https://seanmonstar.com/blog/hyper-http2-continuation-flood/ for more info. * v0.3.26 * fix: return a WriteZero error if frames cannot be written (hyperium#783) Some operating systems will allow you continually call `write()` on a closed socket, and will return `Ok(0)` instead of an error. This patch checks for a zero write, and instead of looping forever trying to write, returns a proper error. Closes hyperium#781 Co-authored-by: leibeiyi <[email protected]> * lints: fix unexpected cfgs warnings * ci: pin deps for MSRV * ci: pin more deps for MSRV job (hyperium#817) * fix: notify_recv after send_reset() in reset_on_recv_stream_err() to ensure local stream is released properly (hyperium#816) Similar to what have been done in fn send_reset<B>(), we should notify RecvStream that is parked after send_reset(). Co-authored-by: Jiahao Liang <[email protected]> --------- Co-authored-by: Sean McArthur <[email protected]> Co-authored-by: dswij <[email protected]> Co-authored-by: Noah Kennedy <[email protected]> Co-authored-by: beiyi lei <[email protected]> Co-authored-by: leibeiyi <[email protected]> Co-authored-by: Jiahao Liang <[email protected]> * v0.3.61 --------- Co-authored-by: Sean McArthur <[email protected]> Co-authored-by: dswij <[email protected]> Co-authored-by: Noah Kennedy <[email protected]> Co-authored-by: beiyi lei <[email protected]> Co-authored-by: leibeiyi <[email protected]> Co-authored-by: Jiahao Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #799