streams: limit error resets for misbehaving connections #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes GOAWAYs to be issued to misbehaving connections which for one reason or another cause us to emit lots of error resets. Error resets are not generally expected from valid implementations anyways. The threshold after which we issue GOAWAYs is tunable, and will default to 1024.
Noah-Kennedy
force-pushed
the
noah/limit-error-resets
branch
from
00a566b
to
892b349
Compare
seanmonstar
reviewed
Jan 17, 2024
seanmonstar
approved these changes
Jan 17, 2024
longbowlu
added a commit
to MystenLabs/sui
that referenced
this pull request
Jan 17, 2024
## Description
```
cargo deny check advisories
error[vulnerability]: Resource exhaustion vulnerability in h2 may lead to Denial of Service (DoS)
┌─ /Users/luzhang/Workplaces/sui/Cargo.lock:415:1
│
415 │ h2 0.3.18 registry+https://github.com/rust-lang/crates.io-index
│ --------------------------------------------------------------- security vulnerability detected
│
= ID: RUSTSEC-2024-0003
= Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0003
= An attacker with an HTTP/2 connection to an affected endpoint can send a steady stream of invalid frames to force the
generation of reset frames on the victim endpoint.
By closing their recv window, the attacker could then force these resets to be queued in an unbounded fashion,
resulting in Out Of Memory (OOM) and high CPU usage.
This fix is corrected in [hyperium/h2#737](hyperium/h2#737), which limits the total number of
internal error resets emitted by default before the connection is closed.
= Solution: Upgrade to ^0.3.24 OR >=0.4.2 (try `cargo update -p h2`)
= h2 v0.3.18
```
## Test Plan
cargo deny check advisories
---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.
### Type of Change (Check all that apply)
- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
### Release notes
This was referenced Jan 18, 2024
Desiki-high
added a commit
to Desiki-high/nydus
that referenced
this pull request
Jan 18, 2024
ID: RUSTSEC-2024-0003 Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0003 An attacker with an HTTP/2 connection to an affected endpoint can send a steady stream of invalid frames to force the generation of reset frames on the victim endpoint. By closing their recv window, the attacker could then force these resets to be queued in an unbounded fashion, resulting in Out Of Memory (OOM) and high CPU usage. This fix is corrected in [hyperium/h2#737](hyperium/h2#737), which limits the total number of internal error resets emitted by default before the connection is closed. Signed-off-by: Yadong Ding <[email protected]>
6 tasks
imeoer
pushed a commit
to dragonflyoss/nydus
that referenced
this pull request
Jan 18, 2024
ID: RUSTSEC-2024-0003 Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0003 An attacker with an HTTP/2 connection to an affected endpoint can send a steady stream of invalid frames to force the generation of reset frames on the victim endpoint. By closing their recv window, the attacker could then force these resets to be queued in an unbounded fashion, resulting in Out Of Memory (OOM) and high CPU usage. This fix is corrected in [hyperium/h2#737](hyperium/h2#737), which limits the total number of internal error resets emitted by default before the connection is closed. Signed-off-by: Yadong Ding <[email protected]>
wlmyng
pushed a commit
to MystenLabs/sui
that referenced
this pull request
Jan 19, 2024
## Description
```
cargo deny check advisories
error[vulnerability]: Resource exhaustion vulnerability in h2 may lead to Denial of Service (DoS)
┌─ /Users/luzhang/Workplaces/sui/Cargo.lock:415:1
│
415 │ h2 0.3.18 registry+https://github.com/rust-lang/crates.io-index
│ --------------------------------------------------------------- security vulnerability detected
│
= ID: RUSTSEC-2024-0003
= Advisory: https://rustsec.org/advisories/RUSTSEC-2024-0003
= An attacker with an HTTP/2 connection to an affected endpoint can send a steady stream of invalid frames to force the
generation of reset frames on the victim endpoint.
By closing their recv window, the attacker could then force these resets to be queued in an unbounded fashion,
resulting in Out Of Memory (OOM) and high CPU usage.
This fix is corrected in [hyperium/h2#737](hyperium/h2#737), which limits the total number of
internal error resets emitted by default before the connection is closed.
= Solution: Upgrade to ^0.3.24 OR >=0.4.2 (try `cargo update -p h2`)
= h2 v0.3.18
```
## Test Plan
cargo deny check advisories
---
If your changes are not user-facing and do not break anything, you can
skip the following section. Otherwise, please briefly describe what has
changed under the Release Notes section.
### Type of Change (Check all that apply)
- [ ] protocol change
- [ ] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration
### Release notes
4 tasks
ryanfrishkorn
added a commit
to ryanfrishkorn/weather-rs
that referenced
this pull request
Feb 2, 2024
See h2 crate security pull request hyperium/h2#737
ryanfrishkorn
added a commit
to ryanfrishkorn/morpha
that referenced
this pull request
Feb 2, 2024
See h2 security pull request: hyperium/h2#737
antonta0
added a commit
to antonta0/u2h
that referenced
this pull request
Feb 12, 2024
antonta0
added a commit
to antonta0/u2h
that referenced
this pull request
Feb 12, 2024
This was referenced Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes GOAWAYs to be issued to misbehaving connections which for one reason or another cause us to emit lots of error resets.
Error resets are not generally expected from valid implementations anyways.
The threshold after which we issue GOAWAYs is tunable, and will default to 1024.