when receiving a GOAWAY, allow earlier streams to still process #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this broke h2spec, expecting the connection to have closed, so I'll need to add the second step into this PR as well: detecting when the streams are finished and return the goaway + close. |
|
LGTM so far (minus h2spec failure) |
seanmonstar
force-pushed
the
recv-go-away
branch
from
252e306
to
4854b69
Compare
Once all active streams have finished, send a GOAWAY back and close the connection.
seanmonstar
force-pushed
the
recv-go-away
branch
from
4854b69
to
2f92284
Compare
|
Updated to now look for when all active streams have finished, and responds with a new GOAWAY and shuts down. |
carllerche
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step to better GOAWAY support (cc #83). This patch will close all streams greater than the last stream ID in the GOAWAY frame, but allow streams less than to still finish.