Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mod / type visibility #4

Closed
carllerche opened this issue Jul 18, 2017 · 0 comments
Closed

Fix mod / type visibility #4

carllerche opened this issue Jul 18, 2017 · 0 comments
Assignees
@olix0r

Comments

@carllerche
Copy link
Collaborator

I started the code making everything public. This was just to get things to compile and because I wasn't sure what the public API would be yet.

We probably should fix this before going too much further as it might require some refactoring.

Roughly, the visibility should be:

Public

  • client mod
  • server mod
  • error mod

Private

  • hpack mod
  • frame mod
  • proto mod
@olix0r olix0r closed this as completed Jul 26, 2017
cxw620 pushed a commit to cxw620/h2 that referenced this issue Jan 20, 2025
@0x676e67 @4JX
@seanmonstar @dswij @Noah-Kennedy
Merge patch (hyperium#4)
64eaf51 
* Add a setter for header_table_size

* Include a test for setting header_table_size

* Fix formatting

* Switch pseudo header order to mimic chrome

* support chrome/okhttp impersonate

* deps(http): bump version to v0.2.11

* feat(header): support safari header pseudo order

* Send frames based on custom configuration

* Revert "deps(http): bump version to v0.2.11"

* deps(http): bump version to v0.2.11

* bump version to v0.4.2

* fix: streams awaiting capacity lockout (hyperium#730) (hyperium#734)

This PR changes the the assign-capacity queue to prioritize streams that
are send-ready.

This is necessary to prevent a lockout when streams aren't able to proceed while
waiting for connection capacity, but there is none.

Closes hyperium/hyper#3338

Co-authored-by: dswij <[email protected]>

* streams: limit error resets for misbehaving connections

This change causes GOAWAYs to be issued to misbehaving connections which for one reason or another cause us to emit lots of error resets.

Error resets are not generally expected from valid implementations anyways.

The threshold after which we issue GOAWAYs is tunable, and will default to 1024.

* Prepare v0.3.24

* perf: optimize header list size calculations (hyperium#750)

This speeds up loading blocks in cases where we have many headers already.

* deps(http): v0.2

* Fix header order

* Optimize pseudo-header sort

* Setting static headers

* feat(frame): Passing values ​​to solve pseudo order

* Add headers priority

* Fix default flag

* Project rename to `h2-patch`
---------

Co-authored-by: 4JX <[email protected]>
Co-authored-by: Sean McArthur <[email protected]>
Co-authored-by: dswij <[email protected]>
Co-authored-by: Noah Kennedy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olix0r olix0r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carllerche @olix0r