Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show thread names in GDB for better debugging #848

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

m-seker
Copy link
Contributor

@m-seker m-seker commented Jun 27, 2020

Summary
Before :

(gdb) info threads 
Id   Target Id         Frame 
* 1    Thread 0x7ffff7fc8400 (LWP 8738) "hyperiond" 0x00007ffff3c22bf9 in __GI___poll (fds=0x55555611f8d0, nfds=7, timeout=62) at ../sysdeps/unix/sysv/linux/poll.c:29
  2    Thread 0x7fffea135700 (LWP 8743) "QXcbEventReader" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffea134ca8, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  3    Thread 0x7fffdf001700 (LWP 8744) "QDBusConnection" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffd8019170, nfds=4, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  4    Thread 0x7fffde2e7700 (LWP 8745) "hyperiond" 0x00007ffff3c22bf9 in __GI___poll (fds=0x55555600a970, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  5    Thread 0x7fffdd981700 (LWP 8746) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffd0009f80, nfds=1, timeout=20) at ../sysdeps/unix/sysv/linux/poll.c:29
  6    Thread 0x7fffdd180700 (LWP 8747) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffd4004bb0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  7    Thread 0x7fffdc97f700 (LWP 8748) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffc80056b0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  8    Thread 0x7fffcffff700 (LWP 8749) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffc4029350, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  9    Thread 0x7fffcf7fe700 (LWP 8750) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffbc00c7b0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  10   Thread 0x7fffceb32700 (LWP 8751) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffc000b600, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  11   Thread 0x7fffce331700 (LWP 8752) "QThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffb40071c0, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  12   Thread 0x7fffcd8a3700 (LWP 8753) "Effect" 0x00007ffff3c2503f in __GI___select (nfds=0, readfds=0x0, writefds=0x0, exceptfds=0x0, timeout=0x7fffcd8a2860) at ../sysdeps/unix/sysv/linux/select.c:41
  13   Thread 0x7fffcd0a2700 (LWP 8754) "Effect" 0x00007ffff3c2503f in __GI___select (nfds=0, readfds=0x0, writefds=0x0, exceptfds=0x0, timeout=0x7fffcd0a1860) at ../sysdeps/unix/sysv/linux/select.c:41
  14   Thread 0x7fffb3f7f700 (LWP 8755) "Qt bearer threa" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffa8004e10, nfds=1, timeout=10000) at ../sysdeps/unix/sysv/linux/poll.c:29

After :

(gdb) info threads 
Id   Target Id         Frame 
* 1    Thread 0x7ffff7fc8400 (LWP 9673) "hyperiond" 0x00007ffff3c22bf9 in __GI___poll (fds=0x5555560c80f0, nfds=7, timeout=84) at ../sysdeps/unix/sysv/linux/poll.c:29
  2    Thread 0x7fffea135700 (LWP 9678) "QXcbEventReader" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffea134ca8, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  3    Thread 0x7fffdf001700 (LWP 9679) "QDBusConnection" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffd8018dc0, nfds=4, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  4    Thread 0x7fffde2e7700 (LWP 9680) "hyperiond" 0x00007ffff3c22bf9 in __GI___poll (fds=0x55555600b490, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  5    Thread 0x7fffdd981700 (LWP 9681) "HyperionIManage" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffd0009f80, nfds=1, timeout=39) at ../sysdeps/unix/sysv/linux/poll.c:29
  6    Thread 0x7fffdd180700 (LWP 9682) "FlatBufferServe" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffd4004b40, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  7    Thread 0x7fffdc97f700 (LWP 9683) "ProtoServerThre" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffc80056b0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  8    Thread 0x7fffcffff700 (LWP 9684) "WebServerThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffc4005a70, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:2
  9    Thread 0x7fffcf7fe700 (LWP 9685) "LedDeviceWrappe" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffb8006da0, nfds=1, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  10   Thread 0x7fffceffd700 (LWP 9686) "SSLWebServerThr" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffc0029100, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  11   Thread 0x7fffce7fc700 (LWP 9687) "SSDPThread" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffb000c1e0, nfds=2, timeout=-1) at ../sysdeps/unix/sysv/linux/poll.c:29
  12   Thread 0x7fffcdb30700 (LWP 9688) "EffectThread" 0x00007ffff3c2503f in __GI___select (nfds=0, readfds=0x0, writefds=0x0, exceptfds=0x0, timeout=0x7fffcdb2f860) at ../sysdeps/unix/sysv/linux/select.c:41
  13   Thread 0x7fffcd32f700 (LWP 9689) "EffectThread" 0x00007ffff3c2503f in __GI___select (nfds=0, readfds=0x0, writefds=0x0, exceptfds=0x0, timeout=0x7fffcd32e860) at ../sysdeps/unix/sysv/linux/select.c:41
  14   Thread 0x7fffaffff700 (LWP 9690) "Qt bearer threa" 0x00007ffff3c22bf9 in __GI___poll (fds=0x7fffa8004e10, nfds=1, timeout=10363) at ../sysdeps/unix/sysv/linux/poll.c:29

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:
    Improve debugging experience

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@hyperion-project
Copy link

Hello @m-seker 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@brindosch brindosch merged commit 485beab into hyperion-project:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants