libsrc/utils: Do not catch SIGILL signal #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @tuxuser 👋 I'm the Hyperion Project Bot and I want to thank you for To help you and other users test your pull requests faster, 🔗 https://github.com/hyperion-project/hyperion.ng/actions/runs/1918577284 Of course, if you make changes to your PR, I will create a new link. Best regards, |
|
Hey @tuxuser I created a new link to your workflow artifacts: |
|
Hey @tuxuser I created a new link to your workflow artifacts: |
libcrypto performs cpu feature checks on ARM platforms, by calling `OPENSSL_cpuid_setup`. In there, it tries to call various instructions and traps `illegal instructions` aka. non-existing instructions itself. However, as hyperion.ng also tries to trap all signals, the call inside libcrypto is propagated and hyperiond gets killed by itself. This patch lets execution proceed, even when `SIGILL` occurs. References: - libcrypto OPENSSL_cpuid_setup: https://github.com/openssl/openssl/blob/954f45ba4c504570206ff5bed811e512cf92dc8e/crypto/armcap.c#L183
|
Many thanks for your support. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
libcrypto performs cpu feature checks on ARM platforms, by calling
OPENSSL_cpuid_setup.In there, it tries to call various instructions and traps
illegal instructionsaka. non-existing instructions itself.However, as hyperion.ng also tries to trap all signals, the call inside libcrypto is propagated and hyperiond gets killed by itself.
This patch lets execution proceed, even when
SIGILLoccurs.References:
What kind of change does this PR introduce? (check at least one)
If changing the UI of web configuration, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing setups:
The PR fulfills these requirements:
Fixes: #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: