Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1181 - Effects were not started from tray #1199

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

Lord-Grey
Copy link
Collaborator

Summary

  • Fixes#1181, where Effects were did not start when trigger from from tray
  • Have named constants Fore-/Background priorities and no timeouts for effects
  • Populate setEffect parameters to have a clearly defined behaviour

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Fixes #1181

@Lord-Grey Lord-Grey added the Bug label Mar 4, 2021
@Lord-Grey Lord-Grey self-assigned this Mar 4, 2021
@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@hyperion-project
Copy link

Here is your new link to your workflow artifacts.

@Lord-Grey Lord-Grey assigned Lord-Grey and unassigned Lord-Grey Mar 4, 2021
@Lord-Grey Lord-Grey merged commit 94d9b02 into hyperion-project:master Mar 19, 2021
@Lord-Grey Lord-Grey deleted the Fix_#1181 branch November 20, 2021 16:43
EliteScientist pushed a commit to EliteScientist/hyperion.ng that referenced this pull request Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants