Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1015 - Fix Lightpack / Remove Multi-Lightpack #1049

Merged
merged 3 commits into from
Oct 18, 2020

Conversation

Lord-Grey
Copy link
Collaborator

Summary

  • Fix Lightpack open, close, update order issue.
  • Replace Multi-Lightpack by multi-instance Lightpack configuration

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated (docs/docs/en)
  • Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

  • Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
Fixes: #1015

@Lord-Grey Lord-Grey self-assigned this Oct 16, 2020
@Lord-Grey Lord-Grey added the Bug label Oct 16, 2020
@hyperion-project
Copy link

Hello @Lord-Grey 👋

I'm your friendly neighborhood bot and would like to say thank you for
submitting a pull request to Hyperion!

So that you and other users can test your changes more quickly,
you can find your workflow artifacts here.

If you make changes to your PR, i create a new link to your workflow artifacts.

Best regards,
Hyperion-Project

@Paulchen-Panther Paulchen-Panther merged commit db1dae4 into hyperion-project:master Oct 18, 2020
@Lord-Grey Lord-Grey deleted the Fix_#1015 branch October 19, 2020 17:05
@Lord-Grey Lord-Grey mentioned this pull request Oct 24, 2020
1 task
@Paulchen-Panther Paulchen-Panther mentioned this pull request Mar 25, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lightpack doesnt work
2 participants