Remove redundant setAccessible methods (#5811)

hyperf · Jun 7, 2023 · b6ad996 · b6ad996
1 parent 80da6ca
commit b6ad996
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/tests/LoggerFactoryTest.php b/tests/LoggerFactoryTest.php
@@ -32,6 +32,10 @@
  * @coversNothing
  */
 #[\PHPUnit\Framework\Attributes\CoversClass(\Hyperf\Logger\LoggerFactory::class)]
+/**
+ * @internal
+ * @coversNothing
+ */
 class LoggerFactoryTest extends TestCase
 {
     protected function tearDown(): void
@@ -64,7 +68,6 @@ public function testHandlerConfig()
         $this->assertInstanceOf(\Hyperf\Logger\Logger::class, $logger);
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('handlers');
-        $handlersProperty->setAccessible(true);
         $handlers = $handlersProperty->getValue($logger);
         $this->assertCount(1, $handlers);
         $this->assertInstanceOf(StreamHandler::class, current($handlers));
@@ -78,7 +81,6 @@ public function testHandlersConfig()
         $this->assertInstanceOf(\Hyperf\Logger\Logger::class, $logger);
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('handlers');
-        $handlersProperty->setAccessible(true);
         $handlers = $handlersProperty->getValue($logger);
         $this->assertCount(2, $handlers);
         $this->assertInstanceOf(StreamHandler::class, $handlers[0]);
@@ -93,7 +95,6 @@ public function testHandlerGroupNotWorks()
         $this->assertInstanceOf(\Hyperf\Logger\Logger::class, $logger);
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('handlers');
-        $handlersProperty->setAccessible(true);
         $handlers = $handlersProperty->getValue($logger);
         $this->assertCount(1, $handlers);
         $this->assertInstanceOf(StreamHandler::class, $handlers[0]);
@@ -102,7 +103,6 @@ public function testHandlerGroupNotWorks()
         $this->assertInstanceOf(\Hyperf\Logger\Logger::class, $logger);
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('handlers');
-        $handlersProperty->setAccessible(true);
         $handlers = $handlersProperty->getValue($logger);
         $this->assertCount(2, $handlers);
         $this->assertInstanceOf(StreamHandler::class, $handlers[0]);
@@ -116,7 +116,6 @@ public function testNotSetProcessor()
         $logger = $factory->get('hyperf');
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('processors');
-        $handlersProperty->setAccessible(true);
         $processors = $handlersProperty->getValue($logger);
         $this->assertSame([], $processors);
     }
@@ -128,7 +127,6 @@ public function testProcessor()
         $logger = $factory->get('hyperf', 'processor-test');
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('processors');
-        $handlersProperty->setAccessible(true);
         $processors = $handlersProperty->getValue($logger);
         $this->assertSame(3, count($processors));
         $this->assertInstanceOf(FooProcessor::class, $processors[0]);
@@ -150,7 +148,6 @@ public function testDefaultProcessor()
         $logger = $factory->get('hyperf', 'default-processor');
         $reflectionClass = new ReflectionClass($logger);
         $handlersProperty = $reflectionClass->getProperty('processors');
-        $handlersProperty->setAccessible(true);
         $processors = $handlersProperty->getValue($logger);
         $this->assertSame(1, count($processors));
         $this->assertInstanceOf(FooProcessor::class, $processors[0]);