Skip to content
This repository has been archived by the owner on May 27, 2023. It is now read-only.

Updating v0.2 to be working now #17

Open
wants to merge 5 commits into
base: feat/v0.2
Choose a base branch
from
Open

Updating v0.2 to be working now #17

wants to merge 5 commits into from

Conversation

GoldenGamerLP
Copy link

Fixed major issues with codeql, legacylookup, and utf-8 encoding. Also added better gradle maintaining support.

@GoldenGamerLP
!Reformat Code by IntelliJ
6cf300a 
Added version properties in all build.gradle.kts for easier maintaining
@GoldenGamerLP
Updated Minestom Version
bcfebdd 
Updated codeql
@GoldenGamerLP
Fixed compile error with UTF-8 and the license header in class Schema…
cbf96de 
…ticChunkLoader.java

Fixed not finding legacy data file, imporved read speeds in LegacyLookup.java

Added version lookup into SpongeSchematicReader.java check

Added UTF-8 java compile option too
@GoldenGamerLP
Hot fix, removed logger for file path
d2bdc76
joshuasing
joshuasing suggested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@joshuasing joshuasing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to Scaffolding! Before your changes are merged, please resolve these small problems.

.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
core/src/main/java/dev/hypera/scaffolding/schematic/LegacyLookup.java Show resolved Hide resolved
core/src/main/java/dev/hypera/scaffolding/schematic/LegacyLookup.java Outdated Show resolved Hide resolved
core/src/main/java/dev/hypera/scaffolding/region/Region.java Show resolved Hide resolved
core/src/main/java/dev/hypera/scaffolding/instance/SchematicChunkLoader.java Show resolved Hide resolved
core/src/main/java/dev/hypera/scaffolding/Scaffolding.java Show resolved Hide resolved
@joshuasing
Copy link
Member

Thanks for your contribution, however I feel as if this would take less time if we implemented some of these
changes when we're next available and close this pull request.

What are your thoughts?

@GoldenGamerLP
Updated comments/java docs
3878e09 
Updated README.md
Looked through some files and updated them
@GoldenGamerLP
Copy link
Author

I'm currently working on those fixes. If you want, you can help me here, I would appreciate it if you would.

@GoldenGamerLP
Copy link
Author

+Push

@joshuasing joshuasing added enhancement New feature or request status: invalid This doesn't seem right contributor: needs corrections These changes need corrections before they can be merged blocked: license or copyright invalid This doesn't follow the license or has invalid/missing copyright notices labels Dec 6, 2022
@joshuasing
Copy link
Member

Could you please explain the bug this attempts to fix in LegacyLookup?

I can't see any major differences between your version and the original version except for the use of computeIfAbsent and Int2ObjectOpenHashMap.

@GoldenGamerLP
Copy link
Author

So this pull request has a major fix, the Legacy Json file can now be loaded. Im using Int2ObjectOpenHashMap because in my experience it was always much faster in such huge data models. The other thing is, it fixes for example the git workflow, which did not work. I see no problem why this pull request should no be merged other then the corrections that need to be done.
The license headings of the classes must be taken over by someone else because I have problems with the encoding in intellij.

@GoldenGamerLP
Copy link
Author

  • The whole Project needs an update for version 1.16 and up. Schematics using MCEdit format are corrupted.

@joshuasing joshuasing self-requested a review January 4, 2023 12:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LooFifteen LooFifteen LooFifteen left review comments

@joshuasing joshuasing Awaiting requested review from joshuasing

Assignees
No one assigned
Labels
blocked: license or copyright invalid This doesn't follow the license or has invalid/missing copyright notices contributor: needs corrections These changes need corrections before they can be merged enhancement New feature or request status: invalid This doesn't seem right status: stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GoldenGamerLP @joshuasing @LooFifteen