Fix for BillingClientImpl Crashes - Promise consumed twice #379
Conversation
|
@mitchellmcm27 Could you review this? Looks like the approach is similar to |
| @Override | ||
| public void onBillingSetupFinished(@BillingClient.BillingResponse int responseCode) { | ||
| if (responseCode == BillingClient.BillingResponse.OK ) { | ||
| Log.d(TAG, "billing client ready"); | ||
| callback.run(); | ||
| if (!bSetupCallbackConsumed) { | ||
| bSetupCallbackConsumed = true; |
There was a problem hiding this comment.
I hope you to review the PR in #359 and check if this is really fixing the problem.
There was a problem hiding this comment.
I think the mBillingClient null check and isReady just moved the crash happening a little later. With 359's PR, that fixed where the old billing client was destroyed from the disconnect, but still attempted to be used. With that fix in place, it moved from trying to use an old client, to using a new one, but trying to hit the old promise a second time.
|
Thank you for contribution. I will merge this commit since this looks pretty severe to try for any solution. Let's see how it goes! |
It's quick and dirty but it seems to work for #315. I can't think of a scenario where you would ever want the same listener to hit it's onSetupFinished callback twice. If the app shutdown and restarted, and needed to get a new connection, it would have created a new listener. I also didn't see a way to unsubscribe a listener from the BillingClient.