Add option to switch coloring output in ConsoleRenderer #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #78 diff @@
===================================
Files 13 13
Lines 695 701 +6
Methods 0 0
Messages 0 0
Branches 88 88
===================================
+ Hits 695 701 +6
Misses 0 0
Partials 0 0
|
|
So in principle, I always wanted ConsoleRenderer make the default (the default config and .dev aren’t part of any backward compatibility promises), how about we make it default and if colorama is missing, it switches automatically to colorize=False (although I think we should it call just |
Emit warning instead of exception when colorama is unavailable and force switch `colors` to `False`
|
Yes, sounds good. I've commited all that things above. |
|
I took a slightly different route but thanks for the inspiration! |
hynek
added a commit
that referenced
this pull request
Sep 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could be useful for plain text file output.