Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Handle Logger.exception() outside "except" block #635

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

WIP: Handle Logger.exception() outside "except" block #635

wants to merge 3 commits into from

Commits on Jul 24, 2024

  1. Handle Logger.exception() outside "except" block 

    Fixes: hynek#634
    @sscherfke
    sscherfke committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    6cc651f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Continue fixing

    @sscherfke
    sscherfke committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a8d2e17 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Try a more radical approach to fix _figure_out_exc_info() 

    The main problem of the function is that *v* can really be anything
(depending on what the users) do and the annotated return type did not
properly match it (e.g., if *v* was "0", the return value would be "0").

The function now rigorously checks the user input and either returns
the desired result (an exc info tuple) or None.  This makes it easier
and safer to use this function.
    @sscherfke
    sscherfke committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    0c02f29 View commit details
    Browse the repository at this point in the history