Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display "exception" logs as level "error" #586

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Display "exception" logs as level "error" #586

merged 4 commits into from
Jan 8, 2024

Conversation

kimsappi
Copy link
Contributor

@kimsappi kimsappi commented Jan 3, 2024

Summary

Changes the displayed log level added by the add_log_level processor for logs using the exception() method to "error" instead of "exception". This replicates the behaviour of CPython and structlog pre-23.3.0 (#572).

This issue has been discussed in #584.

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    • The CI fails with less than 100% coverage.
  • New APIs are added to our typing tests in api.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      • The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

@kimsappi kimsappi changed the title Display "exception" logs as level "error". Closes #584 Display "exception" logs as level "error" Jan 3, 2024
@hynek
Copy link
Owner

hynek commented Jan 4, 2024

Looks good to you @bcdickinson?

@albertferras-vrf
Copy link

Looking forward for this fix. Will you release a hotfix (23.3.1) just with this?

@hynek
Copy link
Owner

hynek commented Jan 5, 2024

No, there’s gonna be a 24.1 soon-ish, there’s been a bunch of other smaller fixes.

CHANGELOG.md Show resolved Hide resolved
src/structlog/_log_levels.py Outdated Show resolved Hide resolved
@hynek hynek merged commit 0b7da28 into hynek:main Jan 8, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants