Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update CMakeModules dependency." #1594

Closed
wants to merge 1 commit into from

Conversation

dabrahams
Copy link
Collaborator

Reverts #1591

Seemingly this broke the build!

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.28%. Comparing base (4a14b77) to head (5012341).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
- Coverage   88.28%   88.28%   -0.01%     
==========================================
  Files         381      381              
  Lines       22910    22910              
==========================================
- Hits        20227    20225       -2     
- Misses       2683     2685       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dabrahams
Copy link
Collaborator Author

That was not the problem

@dabrahams dabrahams closed this Sep 17, 2024
@dabrahams dabrahams deleted the revert-1591-update-cmakemodules branch September 17, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant