Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove needless custom implementation of None.infix== #1565

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

kyouko-taiga
Copy link
Contributor

@kyouko-taiga kyouko-taiga commented Aug 22, 2024

Now that infix== is synthesizable, there is no need to keep None's custom implementation.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (0392eff) to head (9fdd999).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1565      +/-   ##
==========================================
+ Coverage   87.64%   87.66%   +0.01%     
==========================================
  Files         373      373              
  Lines       22614    22620       +6     
==========================================
+ Hits        19821    19829       +8     
+ Misses       2793     2791       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyouko-taiga kyouko-taiga merged commit e47c274 into main Aug 22, 2024
16 checks passed
@kyouko-taiga kyouko-taiga deleted the synthetic-none-equal branch August 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant