Implement MutatingSlice
#1561
Draft
Implement MutatingSlice
#1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Name resolution may fail to resolve the right subscript variant if it is looked up from a generic type conforming to `MutableCollection` without this change. See also https://github.com/orgs/hylo-lang/discussions/1553
dabrahams
reviewed
Sep 16, 2024
| /// The "past-the-end" position in `self`. | ||
| private let upper: Base.Position | ||
|
|
||
| /// Creates an instance with the given source. |
There was a problem hiding this comment.
Suggested change
| /// Creates an instance with the given source. | |
| /// Creates an instance projecting the elements at `lower..<upper` in `base`. |
FWIW, "the given" is usually a mistake.
dabrahams
reviewed
Sep 16, 2024
| (self.base == other.base) && (self.lower == other.lower) && (self.upper == other.upper) | ||
| } | ||
|
|
||
| /// Projects a slice of `base` presenting its elements from `lower` to `upper`. |
There was a problem hiding this comment.
A little ambiguous as to whether the range is half-open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything is in the title.