Add && and || operators to compile-time compilation conditions #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Climbing for ConditionTree evaluation
Co-authored-by: Dimi Racordon <[email protected]>
The test was incorrectly expecting the parser to skip some branches.
kyouko-taiga
force-pushed
the
Mtalymph-1410
branch
from
9e2de63 to
68dff8f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
+ Coverage 87.50% 87.54% +0.03%
==========================================
Files 372 372
Lines 22467 22523 +56
==========================================
+ Hits 19660 19718 +58
+ Misses 2807 2805 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is finishing the work started by @Metalymph on logic operators in compile-time conditions (see #1358). The original PR was #1410.