Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpret wildcard without let as sugar for let wildcard #1348

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Interpret wildcard without let as sugar for let wildcard #1348

merged 2 commits into from
Feb 16, 2024

Conversation

peter-evans
Copy link
Contributor

Closes #977

  • Returns .let as the introducer from parseBindingIntroducer when the current token is _

kyouko-taiga
kyouko-taiga requested changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, I didn't expect it would be that simple!

I just think you should add a note in the docs of parseBindingIntroducer to warn about the fact that this parser now consumes _ if it's the next token of the stream.

kyouko-taiga
kyouko-taiga approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@kyouko-taiga kyouko-taiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyouko-taiga kyouko-taiga merged commit 0fcbd59 into hylo-lang:main Feb 16, 2024
9 checks passed
@peter-evans peter-evans deleted the let-sugar branch April 25, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyouko-taiga kyouko-taiga kyouko-taiga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interpret _ = rhs as a sugar for let _ = rhs
2 participants
@peter-evans @kyouko-taiga