feat(modules): add import!() expression #898
Conversation
I had some trouble getting it to parse because mod is a keyword rather than ident. I can look into it again now though. I agree that whatever thing is used it should be reserved inside and outside modules. |
zzlk
force-pushed
the
imports
branch
3 times, most recently
from
0476901 to
3ed703e
Compare
|
Some things that are not yet done (I think these will likely turn into github issues that we can address later).
|
zzlk
force-pushed
the
imports
branch
3 times, most recently
from
0120512 to
a5dc7b9
Compare
| self.merge_in(flat_graph, import.span()) | ||
| } |
There was a problem hiding this comment.
Call merge_modules here instead? And/or move that code here/into FlatGraphBuilder?
There was a problem hiding this comment.
I think name resolution needs to happen before merge_modules is called.
hydroflow_lang/src/graph/mod.rs
Outdated
| if !diagnostics.iter().any(Diagnostic::is_error) { | ||
| flat_graph.merge_modules(); |
There was a problem hiding this comment.
Call merge_modules be called right when the import is handled?
There was a problem hiding this comment.
I think it needs to happen after name resolution.
hydroflow_macro/src/lib.rs
Outdated
| let flat_graph_builder = FlatGraphBuilder::from_hfcode(input, macro_invocation_path); | ||
| let (mut flat_graph, _uses, diagnostics) = flat_graph_builder.build(); | ||
| if !diagnostics.iter().any(Diagnostic::is_error) { | ||
| flat_graph.merge_modules(); |
There was a problem hiding this comment.
what does the dot mean?
There was a problem hiding this comment.
Oh, also could move merge_modules out of here if it is done automatically
| impl Display for PortIndexValue { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| match self { | ||
| PortIndexValue::Int(x) => write!(f, "{}", x.to_token_stream().to_string()), | ||
| PortIndexValue::Path(x) => write!(f, "{}", x.to_token_stream().to_string()), | ||
| PortIndexValue::Elided(_) => write!(f, "[]"), | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
It's used when outputting an error message about incorrect ports. It's in remove_module_boundary
No description provided.