Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/refactor old stateful/replaying operators #1058

Closed
2 of 4 tasks
MingweiSamuel opened this issue Feb 5, 2024 · 3 comments
Closed
2 of 4 tasks

Deprecate/refactor old stateful/replaying operators #1058

MingweiSamuel opened this issue Feb 5, 2024 · 3 comments
Assignees
Labels
hydroflow syntax Hydroflow's custom surface syntax

Comments

@MingweiSamuel
Copy link
Member

MingweiSamuel commented Feb 5, 2024

@MingweiSamuel MingweiSamuel added the hydroflow syntax Hydroflow's custom surface syntax label Feb 5, 2024
@MingweiSamuel MingweiSamuel added this to the 0.6 Release milestone Feb 5, 2024
@MingweiSamuel MingweiSamuel self-assigned this Feb 5, 2024
@MingweiSamuel MingweiSamuel added the P0 Highest priority label Feb 5, 2024
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 15, 2024
…via singleton arguments hydro-project#969 hydro-project#1058 (hydro-project#1159)

BREAKING CHANGE: `lattice_bimorphism` ports renamed `items_0`->`0`, `items_1`->`1`
BREAKING CHANGE: `lattice_bimorphism` ports `state_0`, `state_1` removed, changed to use singleton references in the second and third argument positions
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Apr 16, 2024
…via singleton arguments hydro-project#969 hydro-project#1058 (hydro-project#1159)

BREAKING CHANGE: `lattice_bimorphism` ports renamed `items_0`->`0`, `items_1`->`1`
BREAKING CHANGE: `lattice_bimorphism` ports `state_0`, `state_1` removed, changed to use singleton references in the second and third argument positions
MingweiSamuel added a commit that referenced this issue Apr 16, 2024
…via singleton arguments #969 #1058 (#1159)

BREAKING CHANGE: `lattice_bimorphism` ports renamed `items_0`->`0`, `items_1`->`1`
BREAKING CHANGE: `lattice_bimorphism` ports `state_0`, `state_1` removed, changed to use singleton references in the second and third argument positions
@MingweiSamuel MingweiSamuel changed the title Remove old stateful/replaying operators Remove/refactor old stateful/replaying operators Apr 25, 2024
@jhellerstein jhellerstein changed the title Remove/refactor old stateful/replaying operators Deprecate/refactor old stateful/replaying operators May 13, 2024
@jhellerstein
Copy link
Contributor

Replay on joins/bimorphisms is now working correctly by insisting on persisting the inputs (which is required semantically for bimorphism).

Remaining work plan is around references:

  1. Introduce an n-way cross operator to gather refs. Give it a meaningful name (not cross-join; maybe "tuple" or "gatherRefs" or something)
  2. Make sure/rewrite code so that output of the n-way cross is reflected in argument of its consumer.
  3. Check that replay of refs through the cross operator works as expected.

@jhellerstein
Copy link
Contributor

We could do this now, but it would be better to gather more experience, and perhaps wait for more helpers in Hydroflow+ before we remove the more ergonomic existing "convenience" operators.

@jhellerstein jhellerstein modified the milestones: 0.7 Release, 0.8 Release May 20, 2024
@jhellerstein jhellerstein added P1 High priority and removed P0 Highest priority labels May 30, 2024
@jhellerstein jhellerstein modified the milestones: 0.8 Release, 0.9 Release Jul 15, 2024
@MingweiSamuel MingweiSamuel removed the P1 High priority label Jul 16, 2024
@MingweiSamuel MingweiSamuel removed this from the 0.9 Release milestone Jul 16, 2024
@MingweiSamuel
Copy link
Member Author

MingweiSamuel commented Jul 16, 2024

Low priority of 0.9 release - hoping to drive from hydroflow+ use cases, and filter downward what works/is needed

And look at Shadaj's Flo paper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hydroflow syntax Hydroflow's custom surface syntax
Projects
None yet
Development

No branches or pull requests

3 participants