-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate/refactor old stateful/replaying operators #1058
Comments
…via singleton arguments hydro-project#969 hydro-project#1058 (hydro-project#1159) BREAKING CHANGE: `lattice_bimorphism` ports renamed `items_0`->`0`, `items_1`->`1` BREAKING CHANGE: `lattice_bimorphism` ports `state_0`, `state_1` removed, changed to use singleton references in the second and third argument positions
…via singleton arguments hydro-project#969 hydro-project#1058 (hydro-project#1159) BREAKING CHANGE: `lattice_bimorphism` ports renamed `items_0`->`0`, `items_1`->`1` BREAKING CHANGE: `lattice_bimorphism` ports `state_0`, `state_1` removed, changed to use singleton references in the second and third argument positions
Replay on joins/bimorphisms is now working correctly by insisting on persisting the inputs (which is required semantically for bimorphism). Remaining work plan is around references:
|
We could do this now, but it would be better to gather more experience, and perhaps wait for more helpers in Hydroflow+ before we remove the more ergonomic existing "convenience" operators. |
Low priority of 0.9 release - hoping to drive from hydroflow+ use cases, and filter downward what works/is needed And look at Shadaj's Flo paper |
join
withstate_join
which can use keyed datastructures fromstate()
op hash join with keyed storage #969, bypass specifying lifetime after HalfMultisetJoinState causes it to be ignored #564removepersist()
(or replace withstate()
), replace[lattice_]reduce/fold
withstate()
versions Avoid cloning data out ofpersist
/[lattice_]reduce
/[lattice_]fold
#925state_mut()
operator, with extra delete input create a good example with mutable state #785Deprecate message for othersThe text was updated successfully, but these errors were encountered: