Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[columnar] fix issue with vacuum udf looping #92

Merged
merged 2 commits into from
Jun 13, 2023
Merged

[columnar] fix issue with vacuum udf looping #92

merged 2 commits into from
Jun 13, 2023

Conversation

JerrySievert
Copy link
Contributor

Fixes an issue where when using the vacuum UDF, a loop can occur that can cause stripes to continually move and eventually overwrite.

What's changed?

  • moved stripe list generation
  • updated test
  • updated expected results

@JerrySievert JerrySievert added the bug Something isn't working label Jun 12, 2023
@JerrySievert JerrySievert requested review from wuputah and mkaruza June 12, 2023 23:37
@JerrySievert JerrySievert self-assigned this Jun 12, 2023
@wuputah
Copy link
Member

wuputah commented Jun 13, 2023

changelog entry? 😁

@JerrySievert
Copy link
Contributor Author

we're getting there, we're getting there @wuputah

mkaruza
mkaruza approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@mkaruza mkaruza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JerrySievert JerrySievert merged commit bfe7432 into main Jun 13, 2023
@JerrySievert JerrySievert deleted the bugfix_vacuum_udf branch June 13, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaruza mkaruza mkaruza approved these changes

@wuputah wuputah wuputah approved these changes

Assignees

@JerrySievert JerrySievert

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JerrySievert @wuputah @mkaruza