Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[columnar] [Bug] Sequential scan parallel execution OOM #78

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

mkaruza
Copy link
Contributor

@mkaruza mkaruza commented May 9, 2023

When assigning next stripe to be read, workers need to scan complete stripe metadata table and reach stripe which need to be read next. During this fetch and compare of stripe metadata rows memory is never released for stripes that needs to be skipped.
This should be addressed by releasing memory that is not needed.

What's changed?

When assigning next stripe to be read, workers need to scan complete
stripe metadata table and reach stripe which need to be read next.
During this fetch and compare of stripe metadata rows memory is never
released for stripes that needs to be skipped.
This should be addressed by releasing memory that is not needed.
@mkaruza mkaruza requested a review from JerrySievert May 9, 2023 12:47
Copy link
Contributor

@JerrySievert JerrySievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkaruza mkaruza merged commit ac1c5bd into main May 10, 2023
@mkaruza mkaruza deleted the github#77 branch May 10, 2023 05:39
wuputah added a commit that referenced this pull request Jun 23, 2023
add initial workflow to run benchmarks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants