[columnar] delete the scanContext whenever possible after creation #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during logical replication of large tables, multiple
MemoryContext
's are created viaCreateColumnarScanMemoryContext()
and do not get removed, eventually resulting in theOOM
killer killing off the replication process and forcibly restarting the database.since a scan context can get used outside of an actual read, it did not make sense to delete it in
ColumnarEndRead()
, so individual scan contexts are deleted when the function that created them are about to end execution.this eliminates the ever-growing of scan contexts that appear under
TopMemoryContext
, and fixes the leak.