Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[columnar] modify default qual_pushdown_correlation_threshold #159

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

JerrySievert
Copy link
Contributor

The current value of 0.9 (on a scale of 0.0 to 1.0) means that most quals will not be pushed down and thereby no chunk elimination occurs. this PR lowers that value to 0.4, which seems to work well in testing against both the clickbench and warehouse benchmarks.

@JerrySievert JerrySievert added the enhancement New feature or request label Sep 19, 2023
@JerrySievert JerrySievert self-assigned this Sep 19, 2023
Copy link
Member

@wuputah wuputah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerrySievert JerrySievert merged commit 7b29458 into main Sep 19, 2023
@JerrySievert JerrySievert deleted the pushdowns branch September 19, 2023 22:28
@wuputah wuputah mentioned this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants