Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[columnar] Vectorized direct aggregates #143

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[columnar] Vectorized direct aggregates #143

merged 1 commit into from
Sep 12, 2023

Conversation

mkaruza
Copy link
Contributor

@mkaruza mkaruza commented Sep 11, 2023

Handle vacuum process with only one full stripe

  • If there is only one stripe that is populated with maximum number of rows do nothing.

Vector read should count only non deleted rows

  • When reading next vector for processing we should count only rows that are not deleted.

Vectorized direct aggregates

  • Supported version 14/15
  • Reused nodeAgg.c to handle vectorized aggregates
  • Implementation of aggregate function to handle vector input

Add O3 optimization

  • Uses O3 optimization. Flag will be used when COLUMNAR_O3 is set.

@mkaruza
[columnar] Vectorized direct aggregates
100e400 
Handle vacuum process with only one full stripe

* If there is only one stripe that is populated with maximum number of
  rows do nothing.

Vector read should count only non deleted rows

* When reading next vector for processing we should count only rows that are not deleted.

Vectorized direct aggregates

* Supported version 14/15
* Reused nodeAgg.c to handle vectorized aggregates
* Implementation of aggregate function to handle vector input

Add O3 optimization

* Uses O3 optimization. Flag will be used when `COLUMNAR_O3` is set.
@JerrySievert
Copy link
Contributor

are there any additional changes, or is this the public PR of the direct aggregates work?

JerrySievert
JerrySievert approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@JerrySievert JerrySievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously reviewed, lgtm!

@mkaruza mkaruza merged commit 5f97011 into main Sep 12, 2023
@mkaruza mkaruza deleted the direct-aggregates branch September 12, 2023 16:06
@wuputah wuputah mentioned this pull request Sep 12, 2023
Closed
@wuputah wuputah added this to the 1.0.0-rc milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JerrySievert JerrySievert JerrySievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rc
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaruza @JerrySievert @wuputah