[columnar] fixes a state where an explain with cache on can cause a crash #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JerrySievert
force-pushed
the
cache_null_stats_dereference
branch
from
b2f759a to
5b71c05
Compare
wuputah
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
headof the cache linked list should be created when a query is run, when a simple explain is run without running the query, theheadis not initialized.In addition, once it is initialized, it is not being set back to a full reset state of
NULL.What's changed?
A check is now made against
headbeingNULLbefore attempting to iterate the linked list, andheadis set toNULLagain when a new memory context is created for the query. Sinceheadis allocated in the query context, and the context is destroyed, this should be a-ok.fixes #124
also, backports a check against another linked list that fails in
assertwhen asserts are enabled.