Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automated benchmarking v3 #105

Merged
merged 2 commits into from
Jun 30, 2023
Merged

automated benchmarking v3 #105

merged 2 commits into from
Jun 30, 2023

Conversation

wuputah
Copy link
Member

@wuputah wuputah commented Jun 30, 2023

More improvements to the benchmarking actions to match updates made to the benchmarking scripts. Test runs look good and should send everything to bencher once this is merged to main.

Benchmarks are not run on PRs at this time, as the benchmarks run against (i.e. pull) built images that have been published. PRs do not push images so this needs some more effort and thought.

Makes progress on #101.

wuputah added 2 commits June 29, 2023 17:00
* fix AWS cred conflicts
* remove `if` on benchmarks
* name all the things
* add metadata to JSON
Copy link
Contributor

@JerrySievert JerrySievert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

progress in general is good. besides, we still don't know exactly what is best, so better to iterate and figure it out as we go.

so in that spirit: lgtm.

@wuputah wuputah merged commit a62d86b into main Jun 30, 2023
@wuputah wuputah deleted the jd/benchmarking branch June 30, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants