Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use addEventProcessor for compatibility with sentry 4 and 5 #20

Merged

Conversation

jardakotesovec
Copy link
Contributor

Based on example from sentry developer I used addEventProcessor to enrich the event.

If I don't miss something, this could be easy update which has compatibility with both sentry 4 and 5.

@jardakotesovec
Copy link
Contributor Author

I did some testing with latest 4 and 5 version (using that new cool client option) and it seems working equally well to me. If you would have a chance to review it sometime soon that would be awesome, so it could be used also with version 5.
Thanks!

index.js Show resolved Hide resolved
@fiws fiws added the enhancement New feature or request label Jun 6, 2019
index.js Show resolved Hide resolved
@guischdi
Copy link
Contributor

guischdi commented Jun 6, 2019

Thanks a lot @jardakotesovec
I tested your changes and resolved a minor linting issue. The refactored feature seems to be working perfectly with @sentry/node@4 and @sentry/node@5!

@guischdi guischdi merged commit 827f64d into hydra-newmedia:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants