BUGFIX: some failing tests

Makefile

@@ -1,14 +1,15 @@
 .PHONY: test race cover robeaux examples test_with_coverage fmt_check
 
-excluding_vendor := $(shell go list ./... | grep -v /vendor/)
+# opencv platform currently skipped to prevent install of preconditions
+including_except := $(shell go list ./... | grep -v platforms/opencv)
 
-# Run tests on all non-vendor directories
+# Run tests on nearly all directories
 test:
-	go test -v $(excluding_vendor)
+	go test -v $(including_except)
 
-# Run tests with race detection on all non-vendor directories
+# Run tests with race detection
 race:
-	go test -race $(excluding_vendor)
+	go test -race $(including_except)
 
 # Check for code well-formedness
 fmt_check:

platforms/beaglebone/beaglebone_adaptor_test.go

@@ -113,11 +113,11 @@ func TestBeagleboneAdaptor(t *testing.T) {
 	gobottest.Assert(t, a.ServoWrite("P9_99", 175), errors.New("Not a valid PWM pin"))
 
 	fs.WithReadError = true
-	gobottest.Assert(t, a.PwmWrite("P9_21", 175), errors.New("read error"))
+	gobottest.Assert(t, strings.Contains(a.PwmWrite("P9_21", 175).Error(), "read error"), true)
 	fs.WithReadError = false
 
 	fs.WithWriteError = true
-	gobottest.Assert(t, a.PwmWrite("P9_22", 175), errors.New("write error"))
+	gobottest.Assert(t, strings.Contains(a.PwmWrite("P9_22", 175).Error(), "write error"), true)
 	fs.WithWriteError = false
 
 	// Analog

platforms/chip/chip_adaptor_test.go

@@ -208,15 +208,15 @@ func TestAdaptorPwmWriteError(t *testing.T) {
 	fs.WithWriteError = true
 
 	err := a.PwmWrite("PWM0", 100)
-	gobottest.Assert(t, err, errors.New("write error"))
+	gobottest.Assert(t, strings.Contains(err.Error(), "write error"), true)
 }
 
 func TestAdaptorPwmReadError(t *testing.T) {
 	a, fs := initTestChipAdaptor()
 	fs.WithReadError = true
 
 	err := a.PwmWrite("PWM0", 100)
-	gobottest.Assert(t, err, errors.New("read error"))
+	gobottest.Assert(t, strings.Contains(err.Error(), "read error"), true)
 }
 
 func TestChipDefaultBus(t *testing.T) {

platforms/intel-iot/edison/edison_adaptor_test.go

@@ -479,7 +479,7 @@ func TestAdaptorPwmWriteError(t *testing.T) {
 	fs.WithWriteError = true
 
 	err := a.PwmWrite("5", 100)
-	gobottest.Assert(t, err, errors.New("write error"))
+	gobottest.Assert(t, strings.Contains(err.Error(), "write error"), true)
 }
 
 func TestAdaptorPwmReadError(t *testing.T) {
@@ -488,7 +488,7 @@ func TestAdaptorPwmReadError(t *testing.T) {
 	fs.WithReadError = true
 
 	err := a.PwmWrite("5", 100)
-	gobottest.Assert(t, err, errors.New("read error"))
+	gobottest.Assert(t, strings.Contains(err.Error(), "read error"), true)
 }
 
 func TestAdaptorAnalog(t *testing.T) {

platforms/keyboard/keyboard_test.go

@@ -15,23 +15,23 @@ func TestParseEscape(t *testing.T) {
 }
 
 func TestParseHyphen(t *testing.T) {
-	gobottest.Assert(t, Parse(bytes{45, 0, 0}).Key, Escape)
+	gobottest.Assert(t, Parse(bytes{45, 0, 0}).Key, Hyphen)
 }
 
 func TestParseAsterisk(t *testing.T) {
-	gobottest.Assert(t, Parse(bytes{42, 0, 0}).Key, Escape)
+	gobottest.Assert(t, Parse(bytes{42, 0, 0}).Key, Asterisk)
 }
 
 func TestParsePlus(t *testing.T) {
-	gobottest.Assert(t, Parse(bytes{43, 0, 0}).Key, Escape)
+	gobottest.Assert(t, Parse(bytes{43, 0, 0}).Key, Plus)
 }
 
 func TestParseSlash(t *testing.T) {
-	gobottest.Assert(t, Parse(bytes{47, 0, 0}).Key, Escape)
+	gobottest.Assert(t, Parse(bytes{47, 0, 0}).Key, Slash)
 }
 
 func TestParseDot(t *testing.T) {
-	gobottest.Assert(t, Parse(bytes{46, 0, 0}).Key, Escape)
+	gobottest.Assert(t, Parse(bytes{46, 0, 0}).Key, Dot)
 }
 
 func TestParseNotEscape(t *testing.T) {

platforms/raspi/pwm_pin.go

@@ -43,6 +43,11 @@ func (p *PWMPin) Polarity() (polarity string, err error) {
 	return "normal", nil
 }
 
+// SetPolarity does not do anything when using PiBlaster
+func (p *PWMPin) SetPolarity(value string) (err error) {
+	return nil
+}
+
 // InvertPolarity does not do anything when using PiBlaster
 func (p *PWMPin) InvertPolarity(invert bool) (err error) {
 	return nil
@@ -83,7 +88,7 @@ func (p *PWMPin) SetDutyCycle(duty uint32) (err error) {
 	p.dc = duty
 
 	val := gobot.FromScale(float64(p.dc), 0, float64(p.period))
-	
+
 	// never go below minimum allowed duty for pi blaster
 	// unless the duty equals to 0
 	if val < 0.05 && val != 0 {

platforms/upboard/up2/adaptor_test.go

@@ -169,15 +169,15 @@ func TestUP2AdaptorPwmWriteError(t *testing.T) {
 	fs.WithWriteError = true
 
 	err := a.PwmWrite("32", 100)
-	gobottest.Assert(t, err, errors.New("write error"))
+	gobottest.Assert(t, strings.Contains(err.Error(), "write error"), true)
 }
 
 func TestUP2AdaptorPwmReadError(t *testing.T) {
 	a, fs := initTestUP2Adaptor()
 	fs.WithReadError = true
 
 	err := a.PwmWrite("32", 100)
-	gobottest.Assert(t, err, errors.New("read error"))
+	gobottest.Assert(t, strings.Contains(err.Error(), "read error"), true)
 }
 
 func TestUP2I2CDefaultBus(t *testing.T) {