Added support for Dualsense joystick (PlayStation 5) #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jig
changed the title
|
Example is being build. It has not to. Fixing it now. |
|
Example building is disabled now. |
|
@jig unfortunatelly I have no such platform and device to test the new driver, but from the code review perspective, it looks good to me. @deadprogram is there anything for you, what is against the merge? |
BUGFIX: circleci new home path now the basic changes are the same like #837
Signed-off-by: deadprogram <[email protected]>
test: make some tests less fragile
Diagonal directions are simply the 2 buttons hit added. Tested on a PowerA Xbox controller
Website documentation did not make this immediately obvious
BUGFIX: some failing tests and implement unused interface
add more platform tests to CI/CD
…wait forever when it is called multiple times Add failing unit tests.
…wait forever when it is called multiple times Fix the issue.
…wait forever when it is called multiple times Fix the test for Halt method so that it waits for all the related goroutines to complete.
|
Hi @jig, please can you change the target branch to dev. Meanwhile I set it back to draft. |
Joystick add Xbox-One controller
Co-authored-by: Thomas Kohler <[email protected]>
Co-authored-by: Thomas Kohler <[email protected]>
|
Hmm, I think I messed the history of this PR @gen2thomas trying to get changes from dev. I will close this PR when I will complete the new one. |
|
This PR has been superseded by #880. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for PlayStation 5 Dualsense joystick.
Code derived from Dualshock 4: