Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adafruit1109 2x16lcd 5keys #812

Merged

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Mar 20, 2022

Introduce a driver for Adafruit product 1109, a 2x16 LCD display with RGB backlit and 5 keys.
The display is driven by the HD44780, and all is connected by i2c port expander MCP23017.
Provides additional bugfix for concurrent writing in HD44780, according to #817 .
Provides stabilization for mcp23017 functions, against concurrent read-write.

@gen2thomas gen2thomas closed this Mar 20, 2022
@gen2thomas gen2thomas reopened this Mar 20, 2022
@gen2thomas gen2thomas marked this pull request as draft March 20, 2022 17:57
@gen2thomas gen2thomas force-pushed the feature/adafruit1109_2x16lcd_5keys branch from 0712ca1 to 0196bb2 Compare March 20, 2022 18:14
@gen2thomas gen2thomas force-pushed the feature/adafruit1109_2x16lcd_5keys branch 2 times, most recently from 7fe44b4 to 49eb64b Compare April 9, 2022 07:59
@gen2thomas gen2thomas marked this pull request as ready for review April 9, 2022 08:07
@gen2thomas
Copy link
Collaborator Author

@deadprogram I'm finished, ready to review

@gen2thomas gen2thomas marked this pull request as draft April 10, 2022 15:56
@gen2thomas
Copy link
Collaborator Author

set back to draft because #817

@gen2thomas gen2thomas force-pushed the feature/adafruit1109_2x16lcd_5keys branch from efbbd50 to 833905e Compare April 10, 2022 16:38
@gen2thomas gen2thomas marked this pull request as ready for review April 10, 2022 16:42
@gen2thomas gen2thomas force-pushed the feature/adafruit1109_2x16lcd_5keys branch from 6415b31 to 792dbcb Compare April 12, 2022 17:11
@gen2thomas gen2thomas force-pushed the feature/adafruit1109_2x16lcd_5keys branch from 4a7ffb7 to 3598e43 Compare April 14, 2022 18:08
@deadprogram
Copy link
Member

Great work on this @gen2thomas thank you very much! Now merging.

@deadprogram deadprogram merged commit 6347285 into hybridgroup:dev Apr 17, 2022
@gen2thomas gen2thomas deleted the feature/adafruit1109_2x16lcd_5keys branch April 18, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants