Skip to content

Commit

Permalink
MINOR: Revert Jetty to 9.4.25 (apache#8183)
Browse files Browse the repository at this point in the history
9.4.25 renamed closeOutput to completeOutput
(jetty/jetty.project@c5acf96),
which is a method used by recent Jersey versions including the
latest (2.30.1). An example of the error:

> java.lang.NoSuchMethodError: org.eclipse.jetty.server.Response.closeOutput()V
> 	at org.glassfish.jersey.jetty.JettyHttpContainer$ResponseWriter.commit(JettyHttpContainer.java:326)

The request still completes and hence why no test fails. We should think about how
to improve the testing for this kind of problem, but I want to get the fix in before
2.5 RC0.

Credit to @rigelbm for finding this.

Reviewers: Ewen Cheslack-Postava <[email protected]>, Andrew Choi <[email protected]>
  • Loading branch information
ijuma authored Feb 27, 2020
1 parent d2c4212 commit 52f36d1
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion gradle/dependencies.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ versions += [
easymock: "4.1",
jackson: "2.10.2",
jacoco: "0.8.3",
jetty: "9.4.26.v20200117",
// 9.4.25 renamed closeOutput to completeOutput (https://github.com/eclipse/jetty.project/commit/c5acf965067478784b54e2d241ec58fdb0b2c9fe)
// which is a method used by recent Jersey versions when this comment was written (2.30.1 was the latest). Please
// verify that this is fixed in some way before bumping the Jetty version.
jetty: "9.4.24.v20191120",
jersey: "2.28",
jmh: "1.23",
hamcrest: "2.2",
Expand Down

0 comments on commit 52f36d1

Please sign in to comment.