Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-0010 Frontend npm update #385

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

hwinther
Copy link
Owner

Description 💬

Motivation and Context 🥅

How has this been tested? 🧪

  • Local build ⚒️
  • Local tests 🧪
  • (optional) Local run and endpoint tested in swagger 🚀

Screenshots (if appropriate) 💻

Types of changes 🌊

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist ☑️

  • The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature"
  • The person responsible for following up on requested review changes has been assigned to the pull request
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Highly optional checks, only use these if you have a reason to do so ✔️

  • This PR changes the database so I have added the create-diagram label to assist reviewers with a db diagram
  • This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the deploy-azure label to deploy before merging the PR

Checklist for the approver ✅

  • I've checked the files view for spelling issues, code quality warnings and similar
  • I've waited until all checks have passed (green check/without error)
  • I've checked that only the intended files are changed

@hwinther hwinther self-assigned this Nov 20, 2024
@hwinther hwinther enabled auto-merge (squash) November 20, 2024 22:22
Copy link

github-actions bot commented Nov 20, 2024

test-e2e

✅ Dependency installation successful

added 637 packages, and audited 638 packages in 5s

✅ Build successful

✅ No linting issues 🎊

Copy link

github-actions bot commented Nov 20, 2024

frontend

✅ Dependency installation successful

added 1031 packages, and audited 1032 packages in 8s

✅ Build successful

✅ No linting issues 🎊

Copy link

Todo Commenter

src/frontend/test/testUtils.tsx
TODO:
  • also remove it afterAll Line: 41

@hwinther Please take a look 👀

Copy link

github-actions bot commented Nov 20, 2024

Playwright results

✅  4 passed

Details

4 tests across 1 suite
 3.7 seconds
 3a30d80

@github-actions github-actions bot added documentation Improvements or additions to documentation github labels Nov 20, 2024
@github-actions github-actions bot added dependencies Pull requests that update a dependency file backend labels Nov 20, 2024
Copy link

✅ Build successful

Copy link

Summary

Summary
Generated on: 11/20/2024 - 22:40:20
Coverage date: 11/20/2024 - 22:40:19
Parser: MultiReport (2x Cobertura)
Assemblies: 1
Classes: 26
Files: 25
Line coverage: 85.1% (648 of 761)
Covered lines: 648
Uncovered lines: 113
Coverable lines: 761
Total lines: 1729
Branch coverage: 66.2% (53 of 80)
Covered branches: 53
Total branches: 80
Method coverage: Feature is only available for sponsors

Coverage

WebApi - 85.1%
Name Line Branch
WebApi 85.1% 66.2%
WebApi.Attributes.DefineConstantsAttribute 100%
WebApi.Controllers.BloggingController 100% 100%
WebApi.Controllers.SendMessageController 100%
WebApi.Controllers.ServiceController 100%
WebApi.Controllers.WeatherForecastController 100%
WebApi.Database.Blog 100%
WebApi.Database.BlogConfiguration 100%
WebApi.Database.BloggingContext 100%
WebApi.Database.Post 100%
WebApi.Database.PostConfiguration 100%
WebApi.Entities.BlogDto 100% 100%
WebApi.Entities.GenericValue`1 100%
WebApi.Entities.PostDto 100% 100%
WebApi.Entities.VersionInformation 100%
WebApi.Entities.WeatherForecast 100%
WebApi.Filters.ValidateModelAttribute 0% 0%
WebApi.Messaging.MessageReceiver 57.6% 20%
WebApi.Messaging.MessageSender 67.9% 37.5%
WebApi.Messaging.RabbitMqHelper 62% 50%
WebApi.Middleware.ExceptionHandlingMiddleware 0% 0%
WebApi.Middleware.ProduceResponseTypeModelProvider 94.4% 75%
WebApi.Migrations.AddBlogMaxLength 82%
WebApi.Migrations.AddBlogTitleField 93.9%
WebApi.Migrations.BloggingContextModelSnapshot 100%
WebApi.Migrations.InitialMigration 94.2%
WebApi.Repository.BloggingRepository 100% 100%
success

Copy link

Code Coverage

Package Line Rate Branch Rate Health
WebApi 85% 66%
Summary 85% (648 / 761) 66% (53 / 80)

@hwinther hwinther disabled auto-merge November 20, 2024 22:40
@hwinther hwinther merged commit 8dace3a into dev Nov 20, 2024
17 checks passed
@hwinther hwinther deleted the feature/TEST-0010-frontend-npm-update branch November 20, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation frontend github playwright
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant