Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-1234 Add additional workflow files and vite frontend #16

Merged
merged 38 commits into from
May 3, 2024

Conversation

hwinther
Copy link
Owner

Description 💬

Motivation and Context 🥅

How has this been tested? 🧪

  • Local build ⚒️
  • Local tests 🧪
  • (optional) Local run and endpoint tested in swagger 🚀

Screenshots (if appropriate) 💻

Types of changes 🌊

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist ☑️

  • The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature"
  • The person responsible for following up on requested review changes has been assigned to the pull request
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Highly optional checks, only use these if you have a reason to do so ✔️

  • This PR changes the database so I have added the create-diagram label to assist reviewers with a db diagram
  • This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the deploy-azure label to deploy before merging the PR

Checklist for the approver ✅

  • I've checked the files view for spelling issues, code quality warnings and similar
  • I've waited until all checks have passed (green check/without error)
  • I've checked that only the intended files are changed

@hwinther hwinther self-assigned this Apr 20, 2024
@hwinther hwinther enabled auto-merge (squash) April 20, 2024 12:23
Copy link

github-actions bot commented Apr 20, 2024

✅ Build successful

Copy link

github-actions bot commented Apr 20, 2024

❌ The following linting issues should be fixed:

  • ❌ warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.

Copy link

Stale pull request message

@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file frontend labels May 3, 2024
Copy link

github-actions bot commented May 3, 2024

✅ frontend: Build successful

Copy link

github-actions bot commented May 3, 2024

✅ frontend: No linting issues 🎊

Copy link

github-actions bot commented May 3, 2024

frontend

✅ Build successful

✅ No linting issues 🎊

@hwinther hwinther force-pushed the feature/TEST-1234-add-playwright2 branch from e1666a8 to 015b2c9 Compare May 3, 2024 19:32
Copy link

github-actions bot commented May 3, 2024

✅ Build successful

Copy link

github-actions bot commented May 3, 2024

Todo Commenter

.github/actions/backend-deploy/action.yml
TODO:
  • terraform has to configure a web hook for each application first in order to skip this step, the web hook url is available from the app deployment center Line: 80
.github/actions/frontend-build/action.yml
TODO:
  • ,FIXME:,BUG:" Line: 149
FIXME:
  • ,BUG:" Line: 149
BUG:
  • " Line: 149
.github/workflows/backend-ci.yml
TODO:
  • ,FIXME:,BUG:" Line: 121
  • move? Line: 123
FIXME:
  • ,BUG:" Line: 121
BUG:
  • " Line: 121

@hwinther Please take a look 👀

Copy link

github-actions bot commented May 3, 2024

Summary

Summary
Generated on: 05/03/2024 - 21:09:27
Coverage date: 05/03/2024 - 21:09:25
Parser: MultiReport (2x Cobertura)
Assemblies: 1
Classes: 3
Files: 3
Line coverage: 100% (57 of 57)
Covered lines: 57
Uncovered lines: 0
Coverable lines: 57
Total lines: 112
Branch coverage: 100% (2 of 2)
Covered branches: 2
Total branches: 2
Method coverage: Feature is only available for sponsors

Coverage

WebApi - 100%
Name Line Branch
WebApi 100% 100%
Program 100% 100%
WebApi.Controllers.WeatherForecastController 100%
WebApi.Entities.WeatherForecast 100%

Copy link

github-actions bot commented May 3, 2024

Code Coverage

Package Line Rate Branch Rate Health
WebApi 100% 100%
Summary 100% (57 / 57) 100% (2 / 2)

@hwinther hwinther disabled auto-merge May 3, 2024 21:10
@hwinther hwinther changed the title TEST-1234 Update example.spec.ts TEST-1234 Add additional workflow files and vite frontend May 3, 2024
@hwinther hwinther merged commit 7005125 into main May 3, 2024
13 of 16 checks passed
@hwinther hwinther deleted the feature/TEST-1234-add-playwright2 branch May 3, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation frontend github workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant