-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
<!--- Provide a general summary of your changes in the Title above --> ## Description 💬 <!--- Describe your changes in detail --> ## Motivation and Context 🥅 <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How has this been tested? 🧪 <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, tests ran to see how --> <!--- your change affects other areas of the code, etc. --> - [x] Local build ⚒️ - [ ] Local tests 🧪 - [ ] (optional) Local run and endpoint tested in swagger 🚀 ## Screenshots (if appropriate) 💻 ## Types of changes 🌊 <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist ☑️ <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [ ] The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature" - [ ] The person responsible for following up on requested review changes has been assigned to the pull request - [ ] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. ## Highly optional checks, only use these if you have a reason to do so ✔️ - [ ] This PR changes the database so I have added the *create-diagram* label to assist reviewers with a db diagram - [ ] This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the *deploy-azure* label to deploy before merging the PR ## Checklist for the approver ✅ - [ ] I've checked the files view for spelling issues, code quality warnings and similar - [ ] I've waited until all checks have passed (green check/without error) - [ ] I've checked that only the intended files are changed
- Loading branch information
Showing
28 changed files
with
752 additions
and
283 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,7 +119,7 @@ jobs: | |
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
review-message: "Please take a look :eyes:" | ||
tags: "TODO,FIXME,BUG" | ||
tags: "TODO:,FIXME:,BUG:" | ||
|
||
# # TODO: move? | ||
# - name: Super-linter | ||
|
@@ -137,13 +137,16 @@ jobs: | |
|
||
- name: WebApi Tests | ||
run: dotnet test ../../tests/backend/WebApi.Tests --no-restore --collect:"XPlat Code Coverage" --logger "trx;LogFileName=test-results.trx" /p:CollectCoverage=true /p:CoverletOutput="../../tests/backend/WebApi.Tests/TestResults/" /p:CoverletOutputFormat=cobertura | ||
continue-on-error: true | ||
|
||
#- uses: hwinther/test-reporter@dotnet-nunit # TODO: set back to original once nunit is supported: dorny/test-reporter@v1 | ||
- uses: dorny/test-reporter@v1 | ||
id: test-reporter | ||
with: | ||
name: "WebApi Tests" | ||
path: "tests/backend/WebApi.Tests/TestResults/test-results.trx" | ||
reporter: dotnet-trx | ||
fail-on-error: true | ||
reporter: dotnet-trx # dotnet-nunit | ||
fail-on-error: false | ||
|
||
- name: Generate report for all tests | ||
id: reportgenerator | ||
|
@@ -161,7 +164,7 @@ jobs: | |
with: | ||
github-token: ${{ secrets.GITHUB_TOKEN }} | ||
comment-identifier: "${{ env.WORKFLOW_SHORT_NAME }}-reportgenerator" | ||
comment-content: ${{ steps.reportgenerator.outputs.markdown }} | ||
comment-content: ${{ steps.reportgenerator.outputs.markdown }}${{ steps.test-reporter.outputs.conclusion }} | ||
|
||
- name: Code Coverage Report | ||
uses: irongut/[email protected] | ||
|
@@ -203,5 +206,4 @@ jobs: | |
solutionWideAnalysis: true | ||
include: | | ||
**.cs | ||
ignoreIssueType: | ||
PropertyCanBeMadeInitOnly.Global | ||
ignoreIssueType: PropertyCanBeMadeInitOnly.Global |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
using System.ComponentModel.DataAnnotations; | ||
using WebApi.Database; | ||
|
||
namespace WebApi.Entities; | ||
|
||
|
2 changes: 1 addition & 1 deletion
2
src/backend/WebApi/Migrations/20240618183910_InitialMigration.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
2 changes: 1 addition & 1 deletion
2
src/backend/WebApi/Migrations/20240622201804_AddBlogMaxLength.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
96 changes: 96 additions & 0 deletions
96
src/backend/WebApi/Migrations/20240623122654_AddBlogTitleField.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.