Skip to content

Commit

Permalink
TEST-1234 Add emoji changes
Browse files Browse the repository at this point in the history
  • Loading branch information
hwinther-tietoevry authored and hwinther committed Mar 27, 2024
1 parent 35c3e8d commit 5109d7e
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 16 deletions.
6 changes: 2 additions & 4 deletions .githooks/commit-msg
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,13 @@ $DEV_BRANCH)

$MAIN_BRANCH)
error_msg="Aborting commit. Please prefix JIRA issue (${JIRA_TAG}-XXXX) and a verb ${IMPERATIVE_VERBS} to the commit message."
commit_regex_string="^${JIRA_TAG}-[0-9]+ ${IMPERATIVE_VERBS} [A-Za-z0-9 \/\'\,\._-]+$"
commit_regex_string="^${JIRA_TAG}-[0-9]+ ${IMPERATIVE_VERBS} .*$"
;;

\
*)
error_msg="Aborting commit. Please prefix JIRA issue (${JIRA_TAG}-XXXX) and a verb ${IMPERATIVE_VERBS} to the commit message."
commit_regex_string="^${JIRA_TAG}-[0-9]+ ${IMPERATIVE_VERBS} [A-Za-z0-9 \/\'\,\._-]+$"
# echo "Unhandled branch value $current_branch"
# exit 1
commit_regex_string="^${JIRA_TAG}-[0-9]+ ${IMPERATIVE_VERBS} .*$"
;;
esac

Expand Down
4 changes: 2 additions & 2 deletions .githooks/config.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env bash
JIRA_TAG="TEST"
BRANCH_PREFIXES="(feature|bugfix)"
IMPERATIVE_VERBS="(Add|Change|Remove|Fix|Update|Bump|Merge)"
BRANCH_PREFIXES="(feature|🌿|bugfix|🪲)"
IMPERATIVE_VERBS="(Add|➕|Change|🌊|Remove|🌅|Fix|🪲|Update|⚒️|Bump|🤛|Merge|🙈)"
31 changes: 21 additions & 10 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,34 +1,45 @@
<!--- Provide a general summary of your changes in the Title above -->

## Description
## Description 💬
<!--- Describe your changes in detail -->

## Motivation and Context
## Motivation and Context 🥅
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->

## How has this been tested?
## How has this been tested? 🧪
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, tests ran to see how -->
<!--- your change affects other areas of the code, etc. -->
- [ ] Local build
- [ ] Local tests
- [ ] (optional) Local run and endpoint tested in swagger
- [ ] Local build ⚒️
- [ ] Local tests 🧪
- [ ] (optional) Local run and endpoint tested in swagger 🚀

## Screenshots (if appropriate)
## Screenshots (if appropriate) 💻

## Types of changes
## Types of changes 🌊
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

## Checklist
## Checklist ☑️

<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature"
- [ ] The person responsible for following up on requested review changes has been assigned to the pull request
- [ ] My code follows the code style of this project.
- [ ] I've added *create-diagram* or similar labels to generate extra PR artifacts to assist reviewers
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.

## Highly optional checks, only use these if you have a reason to do so ✔️

- [ ] This PR changes the database so I have added the *create-diagram* label to assist reviewers with a db diagram
- [ ] This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the *deploy-azure* label to deploy before merging the PR

## Checklist for the approver ✅

- [ ] I've checked the files view for spelling issues, code quality warnings and similar
- [ ] I've waited until all checks have passed (green check/without error)
- [ ] I've checked that only the intended files are changed

0 comments on commit 5109d7e

Please sign in to comment.