Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stronger explanations #73

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Stronger explanations #73

merged 4 commits into from
Aug 29, 2024

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Aug 7, 2024

  • Add ability to search for literals for stronger explanations
  • Enable stronger explanation for DisjunctiveEdgeFinding

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 60.26490% with 60 lines in your changes missing coverage. Please review.

Project coverage is 65.69%. Comparing base (e55a5d3) to head (549b30e).
Report is 1 commits behind head on develop.

Files Patch % Lines
crates/huub/src/solver/engine.rs 35.71% 27 Missing ⚠️
crates/huub/src/solver/engine/int_var.rs 55.17% 26 Missing ⚠️
crates/huub/src/actions/decision.rs 84.37% 5 Missing ⚠️
...ates/huub/src/solver/engine/propagation_context.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #73      +/-   ##
===========================================
- Coverage    65.95%   65.69%   -0.26%     
===========================================
  Files           41       41              
  Lines         6335     6430      +95     
===========================================
+ Hits          4178     4224      +46     
- Misses        2157     2206      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dekker1 Dekker1 force-pushed the feat/strong_expl branch 3 times, most recently from e652c9b to 6558961 Compare August 13, 2024 03:08
Copy link

codecov bot commented Aug 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@Dekker1 Dekker1 force-pushed the feat/strong_expl branch 2 times, most recently from 1a8cd88 to 9680c1d Compare August 27, 2024 01:32
@AllenZzw AllenZzw force-pushed the feat/strong_expl branch 3 times, most recently from c9c4a92 to cdcbfda Compare August 29, 2024 00:36
Dekker1 and others added 3 commits August 29, 2024 14:58
Note that some propagators (like the disjunctive propagator) depend on
the fact that conflicts are detected on integer domains. Because of the
usage of lazy literals, just checking the value of the literals is not
enough. Literals that have just been created might not have their
correct value yet, since their defining clauses still have to be
communicated to the oracle.
@Dekker1 Dekker1 merged commit 9042c73 into develop Aug 29, 2024
8 of 9 checks passed
@Dekker1 Dekker1 deleted the feat/strong_expl branch August 29, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants