Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid half-reification for literal views #124

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Avoid half-reification for literal views #124

wants to merge 1 commit into from

Conversation

Dekker1
Copy link
Contributor

@Dekker1 Dekker1 commented Sep 24, 2024

Another try at this...

@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 24, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #124 will degrade performances by 77.13%

Comparing Dekker1:feat/no_view_imp (4e04dcd) with develop (9415401)

Summary

❌ 1 regressions
✅ 13 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop Dekker1:feat/no_view_imp Change
❌ satisfaction[amaze3_2012_03_19] 774.1 ms 3,384.7 ms -77.13%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dekker1