Add JEST_ELECTRON_STARTUP_ARGS #29
Conversation
README.md
Outdated
| Run electron with arbitrary arguments. | ||
|
|
||
| ```bash | ||
| JEST_ELECTRON_STARTUP_ARGS='--disable-dev-shm-usage' |
There was a problem hiding this comment.
JEST_ELECTRON_STARTUP_ARGS can contain --no-sandbox?
There was a problem hiding this comment.
Yes. It can contain any arbitrary argument.
There was a problem hiding this comment.
so we can remove the doc of no-sandbox, add a case in additional startup arguments
README.md
Outdated
| @@ -87,7 +87,14 @@ script: | |||
| - npm run test | |||
| ``` | |||
|
|
|||
| - **docker** | |||
There was a problem hiding this comment.
I think there is no need to add this item?
There was a problem hiding this comment.
I found the additional documentation useful for anyone encountering issues when running in docker, such as I did. Do you want me to delete this section in the Readme?
|
Yes, we could do so, I just didn't want to break your interface. |
README.md
Outdated
|
|
||
| ```bash | ||
| JEST_ELECTRON_NO_SANDBOX=1 jest | ||
| JEST_ELECTRON_STARTUP_ARGS='--disable-dev-shm-usage' jest |
There was a problem hiding this comment.
this is typo? should be --no-sandbox!
There was a problem hiding this comment.
You're right. Fixed it.
|
Hi, I implemented all your comments, is there anything else that you need? |
See #27.
Instead of adding another environment variable
JEST_ELECTRON_DISABLE_DEV_SHM_USAGE, I went with a more generic approach of adding aforementioned variable for adding arbitrary arguments to the electron process.I also documented the issues found in #27 in the README.
A merge and publish to NPM would help my team and me a lot :)