-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ImageData instantiation using a source array #45
Conversation
Wow. At first glance, this looks great and comprehensive. The test suite meets my expectations, and it appears to follow the specification. I will take some time to read the specs and go over the algorithms to look for some improvements, and inspect why coverage is reported at |
Hi @jtenner, thanks for replying quickly. The coverage issue was caused by a single line that wasn't covered because of a small typo in the test suite. The issue was fixed in the second commit. |
@jtenner You can decide whether to merge the PR or not. And what is your npm id, you can help to release the new version. |
Thank you @hustcc. I really like this pull request. Just want to give myself a little time with it to make sure everything is truly covered. The honest truth is it was a total oversight of mine not to have included it in the first place :) |
Alright! Looks good. I'm pretty confident this will be okay in production. It's just that this software was downloaded 88k times this week, and I wanted to sit on the pull request until I was absolutely confident it would be okay. @hustcc we can release a minor update Is it possible to get access to publish this on npm as well? npm id: jtenner |
This PR introduces changes in the
ImageData
class to comply with the official specification.Changes
ImageData()
now supports instantiation using the syntax:new ImageData(array, width [, height]);
.describe
block corresponds to each valid way to instantiateImageData
. All tests from the previous version are in the first innerdescribe
block.