+) Fix one memory leak (stop AnimationTimer) (#58)

husker-dev · Nov 22, 2023 · 9b4490c · 9b4490c
1 parent b251c26
commit 9b4490c
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/modules/core/src/main/kotlin/com/huskerdev/openglfx/canvas/GLCanvas.kt b/modules/core/src/main/kotlin/com/huskerdev/openglfx/canvas/GLCanvas.kt
@@ -107,16 +107,18 @@ abstract class GLCanvas(
 
     private var useRenderDoc = false
 
+    private val animationTimer = object : AnimationTimer() {
+        override fun handle(now: Long) {
+            timerTick()
+        }
+    }
+
     init {
         visibleProperty().addListener { _, _, _ -> repaint() }
         widthProperty().addListener { _, _, _ -> repaint() }
         heightProperty().addListener { _, _, _ -> repaint() }
 
-        object: AnimationTimer(){
-            override fun handle(now: Long) {
-                timerTick()
-            }
-        }.start()
+        animationTimer.start()
     }
 
     protected abstract fun timerTick()
@@ -169,6 +171,7 @@ abstract class GLCanvas(
     open fun dispose(){
         disposed = true
         animator = null
+        animationTimer.stop()
         onDispose.dispatchEvent(createDisposeEvent())
     }